Fix - #27294 content updated#27464
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
@Shikha1234 Thanks for submitting this PR! I've edited your post to link your PR to your issue. And thanks for the added detail and context around your changes! We really appreciate all the info and it makes it easier for us to review 💖 I'll get this triaged for review! ⚡ |
|
@cmwilson21 Thank you very much for your help :) |
| @@ -89,8 +89,8 @@ You can make and save changes to the files in your repository. On {% data variab | |||
| 1. In the editor, write a bit about yourself. Try using different Markdown elements. | |||
| {% ifversion code-search-code-view %} | |||
There was a problem hiding this comment.
Hi @Shikha1234, I think we can simplify the versioning here to make it easier for people to see the logic
Can you modify lines 90-97 to the following?
{% ifversion code-search-code-view %}1. Click **Commit changes...**.{% endif %}
1. In the "Commit changes" box, write a commit message that describes your changes.
1. Click **Commit changes**.
There was a problem hiding this comment.
Is it the case that the lines:
1. In the "Propose changes" box, write a commit message that describes your changes.
1. Click **Propose changes**.
were left in erroneously? - I noticed this issue too and glad to see someone was working on a fix! I was struggling to see why there were two instances of the same message in @Shikha1234 's edit!
There was a problem hiding this comment.
@callumjohnspiller, that's right, probably we changed the UI text to "Propose changes" at a certain point in the code search feature's development, then changed it back to "Commit changes" later
|
👋 @Shikha1234 Just checking in! Have you had a chance to review |
|
Hi Team, I have updated the changes mentioned in the comments. Please review and Let me know if any modifications required |
isaacmbrown
left a comment
There was a problem hiding this comment.
Thanks @Shikha1234! 🚀
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Issue:
#27294 Making and committing changes is different from the tutorial experience
Steps to Reproduce:
Navigate to the Hello World quickstart tutorial.
Observe the "Commit changes" box instead of the expected "Propose changes" box in the "Making and committing changes" section.
Description:
This pull request addresses the issue with the tutorial where the "Commit changes" box is displayed instead of the expected "Propose changes" box in the "Making and committing changes" section. The issue has been consistently observed across different browsers (Chrome and Safari) and whether logged in to GitHub in the browser or not.
Changes Made:
I have updated the tutorial content to ensure that the correct terminology, "Propose changes," is displayed in the "Making and committing changes" section, aligning it with the expected tutorial experience.
Closes: #27294
Checklist:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Edited the content from "Propose Changes " to "Commit Changes" in "Making and committing changes
" heading
Check off the following:
[Y] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.