Ruby: Model more flow from splat arguments #13974

hmac · 2023-08-15T16:25:50Z

More precise flow into splat parameters
Ruby: Fix SynthSplatParameterElementNode
Ruby: Restrict parameter nodes
Ruby: Remove duplicate disjuncts
Ruby: Add change note
Ruby: Remove isSplatAll arg/parameter position
Ruby: Handle more splat arg flow

We now precisely track flow from positional arguments to splat parameters, provided that splat arguments are not used and there are no positional parameters after the splat parameter. For example, in this case: def f(x, y, *z); end f(a, b, c, d) we get flow from `c` to `z[0]` and `d` to `z[1]`. We get false flow if there are positional parameters after the splat parameter. For example in this case: def g(x, y, *z, w); end g(a, b, c, d) we get flow from `d` to `z[0]` instead of `w`. We also track flow in this case def f(a, *b) sink b[0] end f(1, *[taint, 2])

Make this class into a proper subclass of `ParameterNodeImpl`, to prevent some consistency test failures.

This is equivalent to isSplat(0).

Allow flow from a splat argument to a positional parameter in cases where there are positional arguments left of the splat. For example: def foo(x, y, z); end foo(1, *[2, 3])

hmac added 7 commits August 15, 2023 11:40

Ruby: Fix SynthSplatParameterElementNode

0339191

Make this class into a proper subclass of `ParameterNodeImpl`, to prevent some consistency test failures.

Ruby: Restrict parameter nodes

0d47dfc

Ruby: Remove duplicate disjuncts

a0f9567

Ruby: Add change note

5ebb85a

Ruby: Remove isSplatAll arg/parameter position

505b99c

This is equivalent to isSplat(0).

Ruby: Handle more splat arg flow

d4f6b5e

Allow flow from a splat argument to a positional parameter in cases where there are positional arguments left of the splat. For example: def foo(x, y, z); end foo(1, *[2, 3])

github-actions bot added documentation Ruby labels Aug 15, 2023

Ruby: Update test fixtures

be45be7

Ruby: Model more flow from splat arguments #13974

Are you sure you want to change the base?

Ruby: Model more flow from splat arguments #13974

Conversation

hmac commented Aug 15, 2023