Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: 'ParsedSequence' lacks proper types and yields 'Unresolved' AST nodes #13836

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Swift: 'ParsedSequence' lacks proper types and yields 'Unresolved' AST nodes #13836

wants to merge 1 commit into from

Conversation

AlexDenisov
Copy link
Contributor

Fixes at least one instance of UnresolvedDotExprs.

@AlexDenisov AlexDenisov requested a review from a team as a code owner July 28, 2023 14:15
MathiasVP
MathiasVP approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once DCA is happy. I wonder if there are other instances where we've made a similar mistake when picking a getter from the Swift AST 🤔

@AlexDenisov
Copy link
Contributor Author

LGTM once DCA is happy. I wonder if there are other instances where we've made a similar mistake when picking a getter from the Swift AST 🤔

Yeah, that's the next step for me to figure out. Now I have better understanding of how to debug these issues.

@redsun82
Copy link
Contributor

redsun82 commented Jul 31, 2023 •
edited

I guess we should beware of Parsed things, it was the same issue with KeyPathExpr 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexDenisov @redsun82 @MathiasVP