Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Match repo state to ignored files list #4602

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Match repo state to ignored files list #4602

merged 4 commits into from
Dec 9, 2021

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Dec 9, 2021 •
edited
Loading

There are a number of file types that were added to the root .gitignore list at some point without all of the existing checked-in copies of those files being removed, which is now a pub publish error. This

  • removes all of the files that are on the .gitignore list but are checked in, and
  • adds generated_plugin_registrant.h to the ignore list, since all of the other generated registrant files are there; it doesn't make sense to remove the .cc files but not the .h files.

No version change: .iml files and generated files don't need to be checked in, so there's no client impact.

No CHANGELOG change: This is uninteresting bulk cleanup.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan-g
Copy link
Contributor Author

(I'm still not completely sold on having a root .gitignore at all, since project directories should have them, but since I know there have been issues with flutter adding new generated files that aren't on the existing projects' ignore lists, for now we can keep this approach.)

mvanbeusekom
mvanbeusekom approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g
Copy link
Contributor Author

Landing on red to fix the tree. Everything but publishable passed in the last run, and publishable passed this time.

@stuartmorgan-g stuartmorgan-g merged commit 2f72b8f into flutter:master Dec 9, 2021
@stuartmorgan-g stuartmorgan-g deleted the ignored-files-cleanup branch December 9, 2021 16:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2021
@engine-flutter-autoroll
2f72b8f Match repo state to ignored files list (flutter/plugins#4602)
b02b3fe
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@stuartmorgan-g @amantoux
Match repo state to ignored files list (flutter#4602)
76d7140 
There are a number of file types that were added to the root `.gitignore` list at some point without all of the existing checked-in copies of those files being removed, which is now a `pub publish` error. This
- removes all of the files that are on the .gitignore list but are checked in, and
- adds generated_plugin_registrant.h to the ignore list, since all of the other generated registrant files are there; it doesn't make sense to remove the .cc files but not the .h files.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@stuartmorgan-g @KyleFin
Match repo state to ignored files list (flutter#4602)
148777a 
There are a number of file types that were added to the root `.gitignore` list at some point without all of the existing checked-in copies of those files being removed, which is now a `pub publish` error. This
- removes all of the files that are on the .gitignore list but are checked in, and
- adds generated_plugin_registrant.h to the ignore list, since all of the other generated registrant files are there; it doesn't make sense to remove the .cc files but not the .h files.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
needs tests p: camera p: google_maps_flutter p: google_sign_in p: image_picker p: local_auth p: path_provider p: shared_preferences p: url_launcher p: video_player platform-linux platform-macos platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @mvanbeusekom