Shared: support quoted operands in access path components#13441
Draft
asgerf wants to merge 4 commits intogithub:mainfrom
Draft
Shared: support quoted operands in access path components#13441asgerf wants to merge 4 commits intogithub:mainfrom
asgerf wants to merge 4 commits intogithub:mainfrom
Conversation
Operands in access path components can now be surrounded by single quotes in order to use reserved characters (commas and brackets) as part of the operand text. As an escape mechanism, two consecutive single quote characters are converted to an individual single quote. This was chosen mainly since other escaping mechanisms are hard to implement efficiently in CodeQL.
asgerf
force-pushed
the
shared/access-path-quotation
branch
from
5503751 to
fc4026f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operand to an access path component can now be be enclosed in single quotes. In this case, any character is allowed in-between the single quotes, and two consecutive single quotes will be interpreted as an individual single quote.
This was motivated by a desire to refer to Ruby's
[]and[]=methods asMethod['[]']andMethod['[]='], respectively. I wanted something general enough to ensure we won't have the same problem in the future, and this ensures that arbitrary strings can now be encoded in the operand.