Ruby: Add a barrier guard for test-and-overwrite #12254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmac
force-pushed
the
unless-barrier-guard
branch
from
089daf4 to
b916978
Compare
hmac
force-pushed
the
unless-barrier-guard
branch
2 times, most recently
from
ee536d2 to
422d3f6
Compare
This pattern is commonly used to sanitize binary enums. For example:
sort_dir = "up" unless sort_dir == "down"
This acts as a barrier guard for taint in `sort_dir` because after this
statement, the variable can only have one of two possible constant
values: `"up"` and `"down"`.
hmac
force-pushed
the
unless-barrier-guard
branch
from
422d3f6 to
1e2a42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pattern is commonly used to sanitize binary enums. For example:
This acts as a barrier guard for taint in
sort_dirbecause after thisstatement, the variable can only have one of two possible constant
values:
"up"and"down".