Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation #1090

Merged
merged 4 commits into from Mar 4, 2023
Merged

Fix typo in documentation #1090

merged 4 commits into from Mar 4, 2023

Conversation

iggy890
Copy link
Contributor

@iggy890 iggy890 commented Feb 28, 2023

Description

This PR fixes a typos in two files: SegmentedControl.md, KeybindingManager.md.

Related Issue

Not related with any issues

  • #ISSUE_NUMBER
    No related issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

No new bugs, issues or UI modification.

Documentation.docc/CodeEditUI/FontPicker.md Outdated Show resolved Hide resolved
Documentation.docc/CodeEditUI/SegmentedControl.md Outdated Show resolved Hide resolved
@lukepistrol lukepistrol marked this pull request as draft February 28, 2023 21:18
@iggy890 iggy890 marked this pull request as ready for review February 28, 2023 21:34
@iggy890 iggy890 changed the title Fix typo in documentation and fix missing links Fix typo in documentation Mar 2, 2023
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 4, 2023

@lukepistrol All the changes requested have been made.

Copy link
Member

@lukepistrol lukepistrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though in future we won't accept PRs only including one or two typo fixes. Please have a look at the issues or create one first.

@lukepistrol lukepistrol merged commit 9276de0 into CodeEditApp:main Mar 4, 2023
2 checks passed
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 4, 2023

@lukepistrol No problem! As you may of seen in the discord I'm working on the terminal with a corresponding issue: # 789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants