if current file is not a main class, 'Run Java' will run previously used app #1301
+107
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testforstephen
requested review from
jdneo,
Eskibear and
CsCherrYY
as code owners
jdneo
reviewed
Feb 24, 2023
| filePath ? vscode.workspace.getWorkspaceFolder(vscode.Uri.file(filePath)) : undefined; | ||
| const launchConfigurations: vscode.WorkspaceConfiguration = vscode.workspace.getConfiguration("launch", workspaceFolder); | ||
| const existingConfigs: vscode.DebugConfiguration[] = launchConfigurations.configurations; | ||
| const existConfig: vscode.DebugConfiguration | undefined = _.find(existingConfigs, (config) => { |
There was a problem hiding this comment.
What if the user has two debug configurations, whose mainClass and projectName are the same but other options like args, vmArgs are different?
There was a problem hiding this comment.
The first one will be used. This might be a rare case, since no complaint received yet.
jdneo
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #1036
Old:
New: