gh-101967: add a missing error check #101968
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
changed the title
positional_only_passed_as_keyword functionpositional_only_passed_as_keyword function
carljm
changed the title
positional_only_passed_as_keyword functionpositional_only_passed_as_keyword function
carljm
approved these changes
Feb 16, 2023
arhadthedev
added
interpreter-core
sobolevn
reviewed
Feb 17, 2023
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
iritkatriel
reviewed
Feb 18, 2023
iritkatriel
approved these changes
Feb 18, 2023
iritkatriel
changed the title
positional_only_passed_as_keyword function
|
The MacOS build failure is unrelated. |
|
Thanks @Eclips4 for the PR, and @iritkatriel for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 18, 2023
(cherry picked from commit 89413bbccb9261b72190e275eefe4b0d49671477) Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
|
GH-102016 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 18, 2023
(cherry picked from commit 89413bb) Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves #101967
According to the semantics of function, I prefered to return
1instead ofNULL. Does it correct?positional_only_passed_as_keywordcan be failed with segfault #101967