Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posixmodule.c doesn't detect xattr support on Linux with non-glibc (e.g. musl) #101857

Closed
thesamesam opened this issue Feb 12, 2023 · 0 comments
Closed

posixmodule.c doesn't detect xattr support on Linux with non-glibc (e.g. musl) #101857

thesamesam opened this issue Feb 12, 2023 · 0 comments
Assignees
@gpshead
Labels
build The build process and cross-build extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@thesamesam
Copy link
Contributor

thesamesam commented Feb 12, 2023 •
edited by bedevere-bot

Bug report

posixmodule.c detects xattr support by checking for __GLIBC__ (and some other conditions) at

cpython/Modules/posixmodule.c

Line 277 in 86ebd5c

#if defined(HAVE_SYS_XATTR_H) && defined(__GLIBC__) && !defined(__FreeBSD_kernel__) && !defined(__GNU__)
. This incorrectly excludes the musl libc,which supports xattr functionality.

On a musl system, it's easy to reproduce with:

>>> import os
>>> os.listxattr 
Traceback (most recent call last): 
	File "", line 1, in
AttributeError: module 'os' has no attribute 'listxattr'

Your environment

Linked PRs
@thesamesam thesamesam added the type-bug An unexpected behavior, bug, or error label Feb 12, 2023
@bedevere-bot bedevere-bot mentioned this issue Feb 12, 2023
Merged
thesamesam added a commit to thesamesam/cpython that referenced this issue Feb 12, 2023
@thesamesam
pythongh-101857: Allow xattr detection on musl libc
94b1a66 
Previously, we checked exclusively for __GLIBC__ (AND'd with some other
conditions). Checking for __linux__ instead should be fine.

This fixes using e.g. os.listxattr() on systems using musl libc.

Bug: https://bugs.gentoo.org/894130
@arhadthedev arhadthedev added the extension-modules C modules in the Modules dir label Feb 13, 2023
gpshead added a commit that referenced this issue Feb 14, 2023
@thesamesam @gpshead
gh-101857: Allow xattr detection on musl libc (#101858)
8be8101 
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other
conditions). Checking for `__linux__` instead should be fine.

This fixes using e.g. `os.listxattr()` on systems using musl libc.

Bug: https://bugs.gentoo.org/894130

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot mentioned this issue Feb 14, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 14, 2023
@thesamesam @gpshead @miss-islington
pythongh-101857: Allow xattr detection on musl libc (pythonGH-101858)
07f1ed0 
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other
conditions). Checking for `__linux__` instead should be fine.

This fixes using e.g. `os.listxattr()` on systems using musl libc.

Bug: https://bugs.gentoo.org/894130

(cherry picked from commit 8be8101)

Co-authored-by: Sam James <sam@gentoo.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@gpshead gpshead added the build The build process and cross-build label Feb 14, 2023
@gpshead gpshead self-assigned this Feb 14, 2023
@gpshead gpshead closed this as completed Feb 14, 2023
gpshead added a commit that referenced this issue May 21, 2023
@miss-islington @thesamesam @gpshead
[3.11] gh-101857: Allow xattr detection on musl libc (GH-101858) (#10…
2e457bc 
…1894)

gh-101857: Allow xattr detection on musl libc (GH-101858)

Previously, we checked exclusively for `__GLIBC__` (AND'd with some other
conditions). Checking for `__linux__` instead should be fine.

This fixes using e.g. `os.listxattr()` on systems using musl libc.

Bug: https://bugs.gentoo.org/894130

(cherry picked from commit 8be8101)

Co-authored-by: Sam James <sam@gentoo.org>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@indygreg indygreg mentioned this issue Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpshead gpshead

Labels
build The build process and cross-build extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpshead @arhadthedev @thesamesam