Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-101097: Switch from standard interval notation to greater or less than signs for random.random()'s documentation #101119

Merged
merged 3 commits into from Jan 22, 2023
Merged

GH-101097: Switch from standard interval notation to greater or less than signs for random.random()'s documentation #101119

merged 3 commits into from Jan 22, 2023
+4 −4

Conversation

novialriptide
Copy link
Contributor

@novialriptide novialriptide commented Jan 18, 2023 •
edited by bedevere-bot

@novialriptide novialriptide requested a review from rhettinger as a code owner Jan 18, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 18, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 18, 2023
rhettinger
rhettinger requested changes Jan 18, 2023
View changes
Doc/library/random.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@rhettinger
Copy link
Contributor

Also update the corresponding docstring in Lib/random.py.

@novialriptide
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from rhettinger Jan 18, 2023
rhettinger
rhettinger requested changes Jan 19, 2023
View changes
Lib/random.py Outdated Show resolved Hide resolved
Doc/library/random.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@novialriptide
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from rhettinger Jan 19, 2023
@rhettinger rhettinger merged commit 8bcd4a6 into python:main Jan 22, 2023
17 checks passed
@miss-islington
Copy link
Contributor

Thanks @novialriptide for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-101246 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2023
@novialriptide @miss-islington
pythonGH-101097: Switch from standard interval notation to greater or…
1a197e0 
… less than signs for random.random()'s documentation (pythonGH-101119)

(cherry picked from commit 8bcd4a6)

Co-authored-by: Andrew Hong <andrewhong@myyahoo.com>
miss-islington added a commit that referenced this pull request Jan 22, 2023
@miss-islington
[3.11] GH-101097: Switch from standard interval notation to greater o…
69d12d8 
…r less than signs for random.random()'s documentation (GH-101119) (GH-101246)

(cherry picked from commit 8bcd4a6)

Co-authored-by: Andrew Hong <andrewhong@myyahoo.com>

Automerge-Triggered-By: GH:rhettinger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in python random.random documentation
4 participants
@novialriptide @bedevere-bot @rhettinger @miss-islington