Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Flow test case generator #11432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Nov 25, 2022

In this PR we

  • Introduce a small script including data to allow executing the flow test case generator script locally.
  • Update the access path printing for CSV format.

This is a warmup PR before migrating the flow test case generator to emit data extensions.

@github-actions github-actions bot added the Java label Nov 25, 2022
@michaelnebel michaelnebel marked this pull request as ready for review Nov 25, 2022
@michaelnebel michaelnebel requested a review from a team as a code owner Nov 25, 2022
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Nov 25, 2022
atorralba
atorralba previously approved these changes Nov 25, 2022
Copy link
Contributor

@atorralba atorralba left a comment

LGTM!

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
</properties>
<dependencies>
Copy link
Contributor

@atorralba atorralba Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably most of these dependencies aren't needed for this test case, but I get that it's a bit of a pain going through all of them to determine which ones can be removed 😄

Copy link
Contributor Author

@michaelnebel michaelnebel Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - you are right.
Note that this is not anything that is executed by the CI but merely some internal tooling for doing developer testing of the flow test case generator.
Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants