Hi there 👋
I'm currently working on SvelteKit. Check it out to quickly build easily understandable and performant web apps.
benmccann
Follow
Pinned
2,170 contributions in the last year
Less
More
Activity overview
Contribution activity
November 2022
Created 52 commits in 15 repositories
Created 3 repositories
- benmccann/playwright-console-bug Svelte
- benmccann/unplugin-icons TypeScript
- benmccann/undici JavaScript
Created a pull request in sveltejs/kit that received 9 comments
[breaking] remove support for encoded directories
This is technically breaking, but only barely. Encoded directories mostly didn't work save for 11 characters. It's not clear to me it's possible to…
+24
−87
•
9
comments
Opened 40 other pull requests in 10 repositories
sveltejs/kit
3
open
13
merged
5
closed
- [chore] don't hardcode port in test
- [fix] enable Vite's modulePreload.polyfill
- [fix] disable Vite's modulePreload
- Upgrade vite-plugin-svelte to 1.3.1
- [fix] preserve Vite CLI opts
- [chore] don't override printUrls
- [chore] upgrade to playwright 1.28.1
- [chore] bump pnpm
- [chore] upgrade marked
- try downgrading sharp to fix vercel deploys
- [feat] warn if svelte not found in dependencies or peerDependencies
- [chore] upgrade minor package versions
- [fix] safely join url segments in manifest
- [fix] remove global variable from test to fix flakiness
- [feat] validate that % is not used
- Upgrade to Vite 4
- Upgrade to Vite 4
- [fix] bump required Vite version and address warning
- Deprecate svelte field in package.json
- [fix] check for private var usage in client code instead of server code
- [docs] add a JSDoc for create_manifest_data
sveltejs/sites
4
merged
3
closed
vitejs/vite
1
open
3
merged
chartjs/chartjs-adapter-luxon
2
merged
antfu/unplugin-icons
1
merged
nodejs/undici
1
merged
chartjs/Chart.js
1
merged
sveltejs/rollup-plugin-svelte
1
merged
rollup/rollup
1
merged
sveltejs/vite-plugin-svelte
1
closed
Reviewed 66 pull requests in 10 repositories
sveltejs/kit
25 pull requests
- updated .server docs to include links to methods
- Added Option to Automatically Add Vitest to New Projects using svelte-create
- [fix] preserve Vite CLI opts
- external fetch calls: ensure serialized cookie values are url-encoded
- adapter-auto: defer adapter installation until required
- always set accept/accept-language headers when making a self-request
- warn if recommended env vars are missing
-
don't hardcode
versionin client bundle - only apply polyfills where necessary
- [feat] install adapters on demand
- Use escape sequences to denote special characters
- [fix] safely join url segments in manifest
- fix outdated error
- [fix] remove global variable from test to fix flakiness
- [docs] explain how to break out of root layout
- Html entities
- narrow down possible status codes for redirects to 300-308
- [fix] prevent usage of unsafe encoded characters in path segments
- Failing test for encoded underscore prefix in route path (https://github.com/sveltejs/kit/issues/7570)
- Error handling docs
- [fix] migration error when using $page.routeId
- [fix] avoid decoding %25 in path segments
-
[fix] don't clean build and output directories when using
--watch - [docs] add service-worker example
- [feat] allow users to override IllegalModuleGuard default behaviour
vitejs/vite
20 pull requests
- feat(build): cleaner logs output
- fix(html): transform relative path with long base in /index.html
- feat(ssr): support external true
- docs: update appType docs
- feat(css): upgrade postcss-modules
- feat(vite): ensure that the file path is correct on case-insensitive systems
- feat(resolve): support subpath imports
- feat: align default chunk and asset file names with rollup
- fix: prefer exports when resolving
- feat(hmr): deduplicate paths and join them with commas
- feat: base without trailing slash
- fix(plugin-vue): support scss/sass/less... hmr on custom template languages(fix #10677)
- docs: fix typo
- fix(ssr): improve missing file error
- fix: support polyfill import paths containing an escaping char (e.g. '\')
- chore: remove parameters that are not used
- docs: Added additional workaround steps for stalled requests
- feat(env): support dotenv-expand to contains process env
-
docs: expand
server.proxydescription - feat: experimental server persistent caching
sveltejs/vite-plugin-svelte
6 pull requests
chartjs/chartjs-adapter-luxon
4 pull requests
sveltejs/sites
4 pull requests
JonasKruckenberg/imagetools
2 pull requests
sveltejs/svelte
2 pull requests
antfu/unplugin-icons
1 pull request
vite-pwa/vite-plugin-pwa
1 pull request
sveltejs/realworld
1 pull request
Created an issue in sveltejs/kit that received 6 comments
Cannot have encoded % in URL outside of parameter
Describe the bug #7521 will not allow you to have a URL like this: Probably the way to fix this is to replace the parameters with placeholders, de…
6
comments
Opened 18 other issues in 8 repositories
sveltejs/kit
2
open
7
closed
- warning printed to console
-
throw error(204)returns invalid response -
throw errorandreturn new Responsebehaving differently -
internal
fetchrequest is not initialized correctly - Asset preloading
-
Do we need a per-platform
atobimplementation? - Upgrade to TypeScript 4.9
- Route encoding scheme needs a rethink
- Don't generate CSS twice
h-a-n-a/magic-string-rs
3
open
sveltejs/sites
1
closed
microsoft/playwright
1
closed
sveltejs/vite-plugin-svelte
1
open
alangpierce/sucrase
1
closed
vitejs/vite
1
open
brillout/json-serializer
1
closed
2
contributions
in private repositories
Nov 5 – Nov 22