Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create modular packages for zipfile and test_zipfile #98098

Open
jaraco opened this issue Oct 8, 2022 · 2 comments
Open

Create modular packages for zipfile and test_zipfile #98098

jaraco opened this issue Oct 8, 2022 · 2 comments
Assignees
@Yhg1s
Labels
type-feature A feature request or enhancement

Comments

@jaraco
Copy link
Member

jaraco commented Oct 8, 2022 •
edited by bedevere-bot

I'm about to embark on once again syncing changes from zipp to zipfile.

Historically, I've manually copied the contents of the cpython branch to the relevant files in this repository, but that process is error prone (because it involves syncing a whole file to a portion of another file).

I'd like to instead create packages for zipfile and test_zipfile, such that the functionality that's synced with zipp can be kept separate from other zipfile functionality. Moreover, late versions of zipp bring in extra dependencies so a package can also serve as a home to vendor such functionality.

I'm not suggesting to change the user's signature at all. The names will still be presented through the zipfile module unchanged.

Linked PRs
@jaraco jaraco added the type-feature A feature request or enhancement label Oct 8, 2022
jaraco added a commit to jaraco/cpython that referenced this issue Oct 8, 2022
@jaraco
pythongh-98098: Move zipfile into a package.
f0e44cb
jaraco added a commit to jaraco/cpython that referenced this issue Oct 8, 2022
@jaraco
pythongh-98098: Move zipfile into a package.
e618f11
@jaraco
Copy link
Member Author

jaraco commented Oct 8, 2022

I tried moving most of zipfile.py to zipfile/_core.py but that caused problems with all of the global constants in that file, many of which are treated as mutable (at least for tests).

jaraco added a commit to jaraco/cpython that referenced this issue Oct 8, 2022
@jaraco
pythongh-98098: Remove _core.
17f9618
jaraco added a commit to jaraco/cpython that referenced this issue Oct 8, 2022
@jaraco
pythongh-98098: Move zipfile into a package.
f10d098
jaraco added a commit to jaraco/cpython that referenced this issue Oct 8, 2022
@jaraco
pythongh-98098: Move zipfile into a package.
0c31ae3
@jaraco jaraco mentioned this issue Oct 8, 2022
Merged
jaraco added a commit to jaraco/zipp that referenced this issue Oct 8, 2022
@jaraco
Move files to a location matching their downstream published location…
8bfee67 
…. Ref python/cpython#98098.
jaraco added a commit to jaraco/cpython that referenced this issue Nov 26, 2022
@jaraco
Merge branch 'main' into pythongh-98098/zipfile-packages
550ac55
jaraco added a commit to jaraco/cpython that referenced this issue Nov 26, 2022
@jaraco
Merge branch 'main' into pythongh-98098/zipfile-packages
4ad5b43
jaraco added a commit that referenced this issue Nov 26, 2022
@jaraco
gh-98098: Create packages from zipfile and test_zipfile (gh-98103)
7796d31 
* gh-98098: Move zipfile into a package.

* Moved test_zipfile to a package

* Extracted module for test_path.

* Add blurb

* Add jaraco as owner of zipfile.Path.

* Synchronize with minor changes found at jaraco/zipp@d9e7f4352d.
jaraco added a commit that referenced this issue Nov 26, 2022
@jaraco
gh-98108: Add limited pickleability to zipfile.Path (GH-98109)
93f22d3 
* gh-98098: Move zipfile into a package.

* Moved test_zipfile to a package

* Extracted module for test_path.

* Add blurb

* Add jaraco as owner of zipfile.Path.

* Synchronize with minor changes found at jaraco/zipp@d9e7f4352d.

* gh-98108: Sync with zipp 3.9.1 adding pickleability.
@hauntsaninja
Copy link
Contributor

hauntsaninja commented Nov 29, 2022

Looks like this can be closed, but not touching it since I see it was assigned to Yhg1s and I don't know what that means

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yhg1s Yhg1s

Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaraco @Yhg1s @hauntsaninja