ceval.c's GETITEM should have asserts, not set exceptions #96518
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before this change: the following segfaults at
Py_INCREF(value)inLOAD_CONST:This is because
PyTuple_GetItemraises and returns NULL, which is never checked for.After the change:
Also,
PyTuple_GET_ITEMalready casts.This is a change that only applies in debug mode to malformed code, so skipping issue/news.