deps: update icu tzdata to 2022b #44283
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29
nodejs-github-bot
added
dependencies
|
The PR for icu-data was merged. With this, new Intl.DateTimeFormat("en-US", {
hour12: false,
timeZone: "America/Santiago",
year: "numeric",
month: "2-digit",
day: "2-digit",
hour: "2-digit",
minute: "2-digit",
second: "2-digit",
timeZoneName: "short"
}).format(new Date("2022-09-05T00:00:00Z"));returns |
VoltrexMaster
approved these changes
Aug 22, 2022
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
added
the
author ready
This was referenced Aug 24, 2022
|
I'm not familiar with how the PR process is here, but i think this needs a second approval, right? @srl295 , I see you have reviewed some of the last tzdata updates, maybe you can take a look at this? |
mhdawson
pushed a commit
that referenced
this pull request
Aug 26, 2022
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed in f59d8d3 |
|
@nodejs/releasers This should be cherry-pickable to v16.x-staging as Node.js 16.17.0 updated to ICU 71.1. Node.js 14 is on ICU 70.1 so would either need a manual backport of this or (potentially more risky) the update to ICU 71.1 followed by cherry-picking this PR. |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: nodejs#44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Sep 16, 2022
Following the documentation at: https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data Refs: nodejs/Release#773 Refs: unicode-org/icu-data#29 PR-URL: #44283 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Following the documentation at:
https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data
This is needed for Chilean users, as DST start was delayed by one week, from September 4 to September 11.
Refs: nodejs/Release#773
Refs: unicode-org/icu-data#29