Fix require()s to support browserify #8
Closed
Conversation
Modify the `require()` call in index.js to use a static relative path, instead of building a dynamic absolute path using `path.join()`. This change is necessary to make the module work with browserify, since browserify does not support dynamic paths in `require()`.
|
Thank you for the quick response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Modify the
require()call in index.js to use a static relative path,instead of building a dynamic absolute path using
path.join().This change is necessary to make the module work with browserify,
since browserify does not support dynamic paths in
require().This patch fixes the problem introduced by 0e974f0 in v1.0.1.
/to @dcodeIO could you please merge and release ASAP?
If you still prefer to use
path.joininstead of relative paths, then there is another possible fix - add abrowserentry to thepackage.jsonto tell browserify to usedist/bcrypt.jsinstead ofindex.jsas the package entry file.Another option is to drop the
index.jsfile and add"main": "dist/bcrypt.js"topackage.json.There are many possible solutions and I don't really care which one will be used at the end, as long as we can get a fixed version in the npm soon.