Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button presses should not trigger zoom #252

Open
oaustegard opened this issue Jun 18, 2022 · 4 comments
Open

Button presses should not trigger zoom #252

oaustegard opened this issue Jun 18, 2022 · 4 comments
Labels
bug good first issue

Comments

@oaustegard
Copy link

@oaustegard oaustegard commented Jun 18, 2022

On the homepage at https://fresh.deno.dev/, viewed in Chrome on iOS iPhone 12, when tapping either of the Example’s plus or minus buttons repeatedly, if your tap speed hits the double-tap threshold the screen zooms unexpectedly to the width of the current number and the button you pressed. On zoom in the two increment/decrement presses are counted, then the zoom happens, on zoom out the zoom out happens first and “eats” the increment/decrement.

Both behaviors are surprising to a user and deserve a more consistent behavior.

@lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jun 18, 2022

I'd be happy to take a PR to fix this. It seems like some oddity in Apple's Safari.

@lucacasonato lucacasonato added bug good first issue labels Jun 20, 2022
@TommyDew42
Copy link
Contributor

@TommyDew42 TommyDew42 commented Jun 20, 2022

Lemme take this up! 🚀

@TommyDew42
Copy link
Contributor

@TommyDew42 TommyDew42 commented Jun 21, 2022

@lucacasonato

I am testing the change in my mobile device. Does fresh server by default listen to network request too? I don't seem to be able to connect to my local server from my mobile device.

@lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jun 21, 2022

@TommyDew42 It binds to localhost by default I think. You may need to explicitly bind to hostname: "0.0.0.0" (you can specify this as an option to start in //www/main.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue
Projects
None yet
Development

No branches or pull requests

3 participants