Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a potential variable misuse bug #93935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LostBenjamin
Copy link

@LostBenjamin LostBenjamin commented Jun 17, 2022

Hi,

This pull request is a fix to a potential variable misuse bug at Lib/test/test_functools.py. Please check the changes.

Best,
Jingxuan

@LostBenjamin LostBenjamin requested a review from rhettinger as a code owner Jun 17, 2022
@cpython-cla-bot
Copy link

@cpython-cla-bot cpython-cla-bot bot commented Jun 17, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 17, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added tests awaiting review labels Jun 17, 2022
@CharlieZhao95
Copy link
Contributor

@CharlieZhao95 CharlieZhao95 commented Jun 17, 2022

Maybe you could read the Python Developer's Guide first to make sure your PR is formatted correctly. The doc will also tell you how to sign the CLA.

@LostBenjamin
Copy link
Author

@LostBenjamin LostBenjamin commented Jun 17, 2022

This PR only changes one line of code. No format is better than taking a brief look at the changed line.

I tried to sign the CLA for multiple times. However, whenever I clicked SIGN IN WITH GITHUB TO AGREE, it shows Thank you for authorizing our application, but the CLA must be signed by the users who contributed to the PR. Authors emails are: LostBenjamin@users.noreply.github.com..

@hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Jun 20, 2022

Thanks for spotting this! Can you reauthor the commit using the email ID you signed the CLA with?

@LostBenjamin
Copy link
Author

@LostBenjamin LostBenjamin commented Jun 21, 2022

@hauntsaninja Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants