Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not specify a Kotlin version in the RN rootProject #33589

Closed

Conversation

cortinico
Copy link
Contributor

@cortinico cortinico commented Apr 7, 2022

Summary

As we introduced KGP inside ReactAndroid (cc @ShikaSD), we now need to specify a version for it (as users will consume that build on Android New Architecture.

Currently, the version is loaded in the RN rootProject which is not available on user's project. I'm cleaning this up.

Changelog

[Internal] - Do not specify a Kotlin version in the RN rootProject

Test Plan

Tested on a nightly version with

npx react-native init RNNightly --version nightly

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 7, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2022

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Apr 7, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: c5babd9
Branch: main

@react-native-bot
Copy link
Collaborator

react-native-bot commented Apr 8, 2022

This pull request was successfully merged by @cortinico in bfc3935.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 8, 2022
@cortinico cortinico deleted the nc/do-not-specify-kotlin-version-in-root-project branch Jun 27, 2022
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants