This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Run go mod tidy -e before building
#730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
force-pushed
the
bugfix/build/go-mod-tidy
branch
from
91330a2 to
a6e6be8
Compare
owen-mc
force-pushed
the
bugfix/build/go-mod-tidy
branch
from
a6e6be8 to
22ccbba
Compare
Prior to this (a) Go will attempt to update go.mod/sum anyhow, and (b) the `mod tidy -e` option isn't available.
|
After looking at this some more I've decided to just gate this by Go >= 1.16 and then commit -- the other options re: checking whether mod-tidy would help or not were tangly and the number of projects lost to a failed |
smowton
approved these changes
May 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this works. The easiest way to test it is to delete lines from go.mod and/or go.sum and check that it works and prints log messages that make sense.