ryanmcdermott / clean-code-javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default objects with Object.assign #286

Open

rtm opened this issue Jan 19, 2020 · 1 comment

rtm commented Jan 19, 2020

No, you should use object spread syntax here.

config = {
      title: "Foo",
      body: "Bar",
      buttonText: "Baz",
      cancellable: true
      ...config};

Contributor

rudotriton commented Jan 22, 2020

There is a pull request for it already: #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.