Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper #24170

Merged
merged 5 commits into from Jan 9, 2021
Merged

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper #24170

merged 5 commits into from Jan 9, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 8, 2021 •
edited by bedevere-bot

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 8, 2021

Thanks for spotting this, @mrluanma.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 8, 2021

@berkerpeksag or @serhiy-storchaka, can one of you review and apply this? #skipnews

@erlend-aasland erlend-aasland changed the title bpo-24464: Call sqlite3.enable_shared_cache() from deprecation wrapper bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper Jan 8, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 8, 2021

Regression caused by #24008

@erlend-aasland erlend-aasland marked this pull request as draft Jan 8, 2021
@erlend-aasland erlend-aasland marked this pull request as ready for review Jan 8, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 8, 2021

Fixed macOS tests. Ready for review, @berkerpeksag / @serhiy-storchaka

berkerpeksag
berkerpeksag requested changes Jan 8, 2021
View changes
Lib/sqlite3/test/dbapi.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Jan 8, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 9, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Jan 9, 2021

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from berkerpeksag Jan 9, 2021
Erlend E. Aasland and others added 2 commits Jan 9, 2021
@berkerpeksag berkerpeksag merged commit d16f617 into python:master Jan 9, 2021
3 checks passed
@berkerpeksag
Copy link
Member

berkerpeksag commented Jan 9, 2021

Thank you.

@erlend-aasland erlend-aasland deleted the bpo-24464-fix branch Jan 9, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper (pyt…
7825cfe 
…honGH-24170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlend-aasland @bedevere-bot @berkerpeksag @the-knights-who-say-ni