Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 670: Mark as Accepted #2522

Merged
merged 3 commits into from Apr 15, 2022
Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 12, 2022

No description provided.

@erlend-aasland erlend-aasland requested a review from vstinner as a code owner Apr 12, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 12, 2022

cc. @encukou

@encukou
Copy link
Member

encukou commented Apr 13, 2022

I noticed Post-History is missing. Do you happen to have the discussion thread links handy?

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 13, 2022

I noticed Post-History is missing. Do you happen to have the discussion thread links handy?

Here's some links to recent discussion. There are also some older discussions; let me know if I should find links to them.

How should I add them? One Post-History header for each, one header with all links on one line? Found out from looking at #2521 :)

UPDATE: Added in 7ab1777

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Fixed some syntax and format issues, otherwise LGTM

pep-0670.rst Outdated Show resolved Hide resolved
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

LGTM, thanks @erlend-aasland !

@CAM-Gerlach CAM-Gerlach merged commit 0666a97 into python:main Apr 15, 2022
4 checks passed
@erlend-aasland erlend-aasland deleted the pep670/accepted branch Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants