http2: set origin name correctly when servername is empty #42838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
nodejs-github-bot
added
http2
RafaelGSS
approved these changes
Apr 23, 2022
VoltrexMaster
approved these changes
Apr 23, 2022
austinkelleher
reviewed
Apr 23, 2022
| @@ -3119,7 +3119,7 @@ function initializeTLSOptions(options, servername) { | |||
| options.ALPNProtocols = ['h2']; | |||
| if (options.allowHTTP1 === true) | |||
| ArrayPrototypePush(options.ALPNProtocols, 'http/1.1'); | |||
| if (servername !== undefined && options.servername === undefined) | |||
| if (servername !== undefined && !options.servername) | |||
There was a problem hiding this comment.
It looks like the referenced PR had the same change and @lpinca had left a comment about the behavior. https://github.com/nodejs/node/pull/39934/files#r699529426
I'm not entirely sure what the desired behavior is here but it's probably worth discussing. In the comment, @lpinca calls out the following commit: 98e9de7
Looking at the latest https documentation, you can see that servername is still documented the same way for https.Agent:
Line 80 in 9cd2c27
There was a problem hiding this comment.
Thanks for your reply, I understand the problem much better now, although I think it is still wired we return https://false.
There was a problem hiding this comment.
Is there any conclusion yet on what needs to be done for this?
|
Can you brebase the change? I think this can land but we need to get ci passing |
ofirbarak
force-pushed
the
fix-invalid-origin-set
branch
from
90bb546
to
10cb6da
Compare
19 tasks
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42838 ✔ Done loading data for nodejs/node/pull/42838 ----------------------------------- PR info ------------------------------------ Title http2: set origin name correctly when servername is empty (#42838) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ofirbarak:fix-invalid-origin-set -> nodejs:master Labels http2 Commits 1 - http2: set origin name correctly when servername is empty Committers 1 - ofir PR-URL: https://github.com/nodejs/node/pull/42838 Fixes: https://github.com/nodejs/node/issues/39919 Refs: https://github.com/nodejs/node/pull/39934 Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42838 Fixes: https://github.com/nodejs/node/issues/39919 Refs: https://github.com/nodejs/node/pull/39934 Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - http2: set origin name correctly when servername is empty ℹ This PR was created on Sat, 23 Apr 2022 13:13:21 GMT ✔ Approvals: 3 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/42838#pullrequestreview-950964984 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/42838#pullrequestreview-950965332 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42838#pullrequestreview-951014402 ⚠ GitHub cannot link the author of 'http2: set origin name correctly when servername is empty' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-05-25T07:19:57Z: https://ci.nodejs.org/job/node-test-pull-request/44157/ - Querying data for job/node-test-pull-request/44157/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2383813741 |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f9f22b4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes: #39919
Refs: #39934