Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: usemustSucceed instead of mustCall with assert.ifError #42806

Merged
merged 1 commit into from May 5, 2022
Merged

test: usemustSucceed instead of mustCall with assert.ifError #42806

merged 1 commit into from May 5, 2022
+2 −4

Conversation

fossamagna
Copy link
Contributor

@fossamagna fossamagna commented Apr 21, 2022

Use mustSucceed instead of mustCall + ifError.

@nodejs-github-bot nodejs-github-bot added needs-ci test labels Apr 21, 2022
lpinca
lpinca approved these changes Apr 21, 2022
View changes
@aduh95 aduh95 added author ready request-ci labels Apr 21, 2022
@github-actions github-actions bot removed the request-ci label Apr 21, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43611/

@github-actions github-actions bot mentioned this pull request Apr 22, 2022
Open
19 tasks
@github-actions github-actions bot mentioned this pull request Apr 23, 2022
Open
21 tasks
@github-actions github-actions bot mentioned this pull request Apr 24, 2022
Open
21 tasks
@github-actions github-actions bot mentioned this pull request Apr 25, 2022
Open
16 tasks
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 28, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43749/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 2, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43830/

@aduh95 aduh95 added the commit-queue label May 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label May 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit a571a3f into nodejs:master May 5, 2022
58 checks passed
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 5, 2022

Landed in a571a3f

RafaelGSS pushed a commit that referenced this issue May 10, 2022
@fossamagna @RafaelGSS
test: usemustSucceed instead of mustCall with assert.ifError
b1c18ed 
PR-URL: #42806
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@cjihrig cjihrig

@RaisinTen RaisinTen

@VoltrexMaster VoltrexMaster

Assignees
No one assigned
Labels
author ready needs-ci test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fossamagna @nodejs-github-bot @lpinca @cjihrig @RaisinTen @VoltrexMaster @aduh95