New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Did you intend to use sizeof (tValuePair *) instead of sizeof (tValuePair **)? #9126

Open

Aries-Lee1991 opened this issue Dec 16, 2021 · 2 comments

Assignees

Labels

good first issue

Contributor

Aries-Lee1991 commented Dec 16, 2021

in https://github.com/taosdata/TDengine/blob/develop/src/query/src/qAggMain.c, Passing argument pList of type tValuePair ** and argument 8 /* sizeof (tValuePair **) */ to function taosheapsort is suspicious. In this case, sizeof (tValuePair **) is equal to sizeof (tValuePair *).

You can use sizeof (tValuePair *) instead of sizeof (tValuePair **).

Aries-Lee1991 added the good first issue label

lihongxing6 commented Dec 16, 2021

pick up challenge

Contributor Author

Aries-Lee1991 commented Dec 16, 2021

pick up challenge

Assigned it to you.

Aries-Lee1991 assigned lihongxing6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment