Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local variable loopCont is assigned only once, to a constant value, making it effectively constant throughout its scope. If this is not the intent, examine the logic to see if there is a missing assignment that would make loopCont not remain constant. #9128

Open
Aries-Lee1991 opened this issue Dec 16, 2021 · 6 comments
Open

Local variable loopCont is assigned only once, to a constant value, making it effectively constant throughout its scope. If this is not the intent, examine the logic to see if there is a missing assignment that would make loopCont not remain constant. #9128

Aries-Lee1991 opened this issue Dec 16, 2021 · 6 comments
Assignees
@sxyseo
Labels
good first issue

Comments

@Aries-Lee1991
Copy link
Contributor

@Aries-Lee1991 Aries-Lee1991 commented Dec 16, 2021

In https://github.com/taosdata/TDengine/blob/develop/src/client/src/tscPrepare.c, Local variable loopCont is assigned only once, to a constant value, making it effectively constant throughout its scope. If this is not the intent, examine the logic to see if there is a missing assignment that would make loopCont not remain constant.

So the 1567th line should be removed.
image
@Aries-Lee1991 Aries-Lee1991 added the good first issue label Dec 16, 2021
@sxyseo
Copy link
Contributor

@sxyseo sxyseo commented Dec 16, 2021

Pick up challenge @Aries-Lee1991

@Aries-Lee1991
Copy link
Contributor Author

@Aries-Lee1991 Aries-Lee1991 commented Dec 16, 2021

Pick up challenge @Aries-Lee1991

@sxyseo You are already a contributor and can no longer receive tasks.

@sxyseo
Copy link
Contributor

@sxyseo sxyseo commented Dec 16, 2021

Pick up challenge @Aries-Lee1991

@sxyseo You are already a contributor and can no longer receive tasks.

ok，the last task was not merged successfully and did not become a real contributor.

#8045

@Aries-Lee1991
Copy link
Contributor Author

@Aries-Lee1991 Aries-Lee1991 commented Dec 16, 2021

Pick up challenge @Aries-Lee1991

@sxyseo You are already a contributor and can no longer receive tasks.

ok，the last task was not merged successfully and did not become a real contributor.

#8045

Sorry，It's ok，assigned it to you.

@sxyseo
Copy link
Contributor

@sxyseo sxyseo commented Dec 30, 2021

The stmtValidateValuesFields method needs a return value.
Personally, I don't think it's appropriate to remove it here.
Maybe I don't understand it correctly.

If I misunderstand the content of this task,
Please give more tips.Thank you.

@sxyseo
Copy link
Contributor

@sxyseo sxyseo commented Dec 30, 2021 •
edited

Pull request for this question

#9524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sxyseo sxyseo

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sxyseo @Aries-Lee1991