Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a core.BlockChainConfig to simplify NewBlockChain #20280

Open
karalabe opened this issue Nov 13, 2019 · 3 comments
Open

Make a core.BlockChainConfig to simplify NewBlockChain #20280

karalabe opened this issue Nov 13, 2019 · 3 comments
Labels
area:core good first issue help wanted type:tech-debt

Comments

@karalabe
Copy link
Member

@karalabe karalabe commented Nov 13, 2019

The function arguments to core.NewBlockChain got way out of hand. We need a config structure instead.
@karalabe karalabe changed the title [Techdebt]: Add core.BlockChainConfig to simplify NewBlockChain Make a core.BlockChainConfig to simplify NewBlockChain Nov 13, 2019
@ducquangkstn ducquangkstn mentioned this issue Nov 16, 2019
Closed
@ducquangkstn
Copy link

@ducquangkstn ducquangkstn commented Nov 17, 2019

@karalabe can you take a look at my PR, tks

@djbehnke
Copy link

@djbehnke djbehnke commented Feb 18, 2020

I made a comment on #20301 but thought I would mention it here. Is this issue a good first issue still? If so why has #20301 not been merged? What needs to be done differently to get this done?

@ethereum ethereum deleted a comment Sep 20, 2020
@ethereum ethereum deleted a comment from Dominik144 Sep 20, 2020
@ethereum ethereum deleted a comment from Domel1985 Sep 20, 2020
@ethereum ethereum deleted a comment Sep 20, 2020
gideongrinberg added a commit to gideongrinberg/go-ethereum that referenced this issue May 29, 2021
@gideongrinberg
Add core.BlockChainConfig (ethereum#20280)
56ca1a5
@gideongrinberg gideongrinberg mentioned this issue May 29, 2021
Closed
gideongrinberg added a commit to gideongrinberg/go-ethereum that referenced this issue May 30, 2021
@gideongrinberg
Add core.BlockChainConfig (ethereum#20280)
c0c7bce
gideongrinberg added a commit to gideongrinberg/go-ethereum that referenced this issue May 30, 2021
@gideongrinberg
Add core.BlockChainConfig (ethereum#20280)
1afa277 
Add core.BlockChainConfig (ethereum#20280)

Add core.BlockChainConfig (ethereum#20280)
gideongrinberg added a commit to gideongrinberg/go-ethereum that referenced this issue May 31, 2021
@gideongrinberg
Add core.BlockChainConfig (ethereum#20280)
ff92bd9
@omkar-mohanty omkar-mohanty mentioned this issue Feb 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:core good first issue help wanted type:tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@karalabe @rjl493456442 @ducquangkstn @djbehnke and others