Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upShould update contact information to not hard-code specific org team mention #63
Comments
|
How about we take out the instruction text/title and make it part of the config? Then any org could custom set whatever message they want to when a CLA is to be signed? I would like to take up this issue please |
|
Hmm, how does per-organization configuration work for GitHub Apps? |
|
Aside from choosing repositories, I don't think per-organization configuration is currently supported by GitHub Apps. All the apps I've seen are configured on a per-repo basis by reading files from the repo. I think it's a no-go to require a config file in every repo of every org that installs the app for this purpose. I would go with @filmaj's approach of changing the message based on org. Let me know if you're still taking the issue @amithkk. |
Currently the bot tells people to at-mention
adobe/open-source-officefor issues. However, if you install this app on an org different from github.com/adobe, you can't mention a team from another org.So should at least update the instruction text we give users to not give them faulty instructions. Perhaps could get the bot to detect whether the PR is happening on the adobe org, and if so, leave those instructions in, otherwise, direct folks to email. Another option is on the magento org could at-mention a different team, like the community-eng team.