Block or Report
Block or report nolanlawson
Report abuse
Contact GitHub support about this user’s behavior. Learn more about reporting abuse.
Report abusePinned
1,558 contributions in the last year
Less
More
Contribution activity
February 2022
Created 76 commits in 13 repositories
Created 3 repositories
Created a pull request in salesforce/lwc-rfcs that received 16 comments
Opened 44 other pull requests in 5 repositories
salesforce/lwc
3
open
13
merged
1
closed
- feat(compiler): add utility for registering stylesheets
- fix(template-compiler): scope keys in default slot content
- fix(template-compiler): inline iterator checks key is not index
- fix(template-compiler): omit api_key for key outside iteration
- feat: compiler version mismatch warnings
- test: update snapshot test
- feat: template compiler versioning
- feat: implement refs
- perf(template-compiler): make empty children implicit
- fix(template-compiler): allow void <path /> tag
- perf(engine-dom): use adoptedStyleSheets.push
- perf: only clone old children once
- chore(perf-benchmarks): tweak default constants
- chore(perf-benchmarks): print results in markdown table
- perf: only add scope token when stylesheets are present
- chore(perf-benchmarks): remove broken WC tests
- chore(nucleus): remove ui-interaction-explorer-components
nolanlawson/emoji-picker-element
16
merged
1
closed
- docs: add demo of using Twemoji
- chore: update fakeindexeddb
- chore: update deps
- chore: update svelte-jester and svelte-preprocess
- chore: update deps
- chore: update rollup
- chore: update deps
- chore: update svelte
- chore: update deps
- chore: fix yarn call in gh action
- chore: update rollup
- chore: update sass and csso
- chore: update jest
- chore: update puppeteer and playwright
- chore: update stylelint
- chore: update dependencies
- fix: customElements.define called twice
nolanlawson/marky
5
merged
1
closed
nolanlawson/pinafore
2
merged
salesforce/lwc-test
2
merged
Reviewed 33 pull requests in 4 repositories
salesforce/lwc
27 pull requests
- fix(template-compiler): scope keys in default slot content
-
chore: remove
noUnusedLocalfromtsconfig.json - refactor(engine-core): Simplify unmount process
- chore: v2.10.0 @W-7258582
- feat(compiler): add utility for registering stylesheets
- chore: v2.10.0
- fix(template-compiler): inline iterator checks key is not index
- feat: compiler version mismatch warnings
- fix(template-compiler): omit api_key for key outside iteration
- refactor(hydration): remove explicit DOM api usages in engine-core
- refactor(engine-core): Remove patching hooks
- chore: weekly dependencies update
- feat: template compiler versioning
- chore(features): DISABLE_MIXED_SHADOW_MODE
- feat: implement refs
- chore(deps-dev): bump karma from 6.3.12 to 6.3.14
- v2.9.0
- chore: v2.9.0
- feat(hydration): support hydration in customElements.define
- perf: only clone old children once
- chore(deps): bump simple-get from 3.1.0 to 3.1.1
- perf: hoist static objects/arrays in templates
- v2.8.0
- chore(perf-benchmarks): print results in markdown table
- v2.8.0
- Some pull request reviews not shown.
salesforce/kagekiri
3 pull requests
nolanlawson/pinafore
2 pull requests
salesforce/lwc-rfcs
1 pull request
Created an issue in salesforce/lwc that received 5 comments
"key" attribute can be used outside of iteration
Description During refactoring (#2677), we found a test in a downstream that broke because of an odd situation: <!-- foo.html --> <template> <x-bar k…
5
comments
Opened 12 other issues in 6 repositories
salesforce/lwc
4
open
3
closed
- [Template compiler] Scope slot keys to avoid mutating vnode.key
- [Template compiler] Inline iterators allow setting a key to an index
- [JS compiler] registerDecorators emitted for non-LightningElement classes
- [Template compiler] Holistic approach to void elements
- [Perf] Hoist static VNodes in template compiler
- [Perf] Only clone VNode children array once
- [Perf] Template compiler should avoid outputting empty children array