initial tests for arguments length #1898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
reviewed
Jun 9, 2021
willemneal
reviewed
Jun 9, 2021
std/assembly/builtins.ts
Outdated
|
|
||
| /* eslint-enable @typescript-eslint/no-unused-vars */ | ||
| @final | ||
| export declare class arguments { |
Contributor
There was a problem hiding this comment.
Is it possible to declare a namespace? If not, that should be an added feature request.
Contributor
Author
(func $builtins/arglength1 (param $0 i32)
(local $1 i32)
(local $2 i32)
global.get $~lib/memory/__stack_pointer
i32.const 4
i32.sub
global.set $~lib/memory/__stack_pointer
call $~stack_check
global.get $~lib/memory/__stack_pointer
i32.const 0
i32.store
+ global.get $~argumentsLength
+ local.set $1
i32.const 1024
local.set $2
global.get $~lib/memory/__stack_pointer
local.get $2
i32.store
local.get $2
i32.const 2
+ call $~lib/builtins/arguments.get:length
f64.convert_i32_s
+ call $~lib/builtins/arguments.get:length
f64.convert_i32_s
f64.const 0
f64.const 0
f64.const 0
call $~lib/builtins/trace
global.get $~lib/memory/__stack_pointer
i32.const 4
i32.add
global.set $~lib/memory/__stack_pointer
)I put a plus sign before the important bits. Looks like it's calling a function instead of getting a local. |
Contributor
Author
|
Of course, it adds a function like this: + (func $~lib/builtins/arguments.get:length (result i32)
+ (local $0 i32)
+ global.get $~argumentsLength
+ local.set $0
+ local.get $0
+ )🙄 |
Remove the line. Weird. Co-authored-by: Willem Wyndham <willem@cs.umd.edu>
jtenner
commented
Jun 13, 2021
| const mod = compiler.module; | ||
| compiler.currentType = Type.i32; | ||
| const local = compiler.currentFlow.lookupLocal(BuiltinNames.argumentsLengthLocal)!; | ||
| return mod.local_get(local.index, TypeRef.I32); |
Contributor
Author
There was a problem hiding this comment.
This becomes the function body of the builtin. Using arguments.length accesses the namespace, and calls the function. This is not desired behavior.
I believe we need to override compilePropertyAccess()
Member
|
clean outdated draft PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⯈ Initial attempt on implementing
arguments.length