Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update property name #42398

Merged
merged 1 commit into from Mar 21, 2022
Merged

doc: update property name #42398

merged 1 commit into from Mar 21, 2022

Conversation

Copy link
Member

@Trott Trott commented Mar 19, 2022

Property name min was updated in 23637e9
to lowest but an instance of min was missed.

Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.
@Trott Trott requested a review from jasnell Mar 19, 2022
@nodejs-github-bot nodejs-github-bot added doc perf_hooks labels Mar 19, 2022
@Trott Trott added the author ready label Mar 19, 2022
Copy link

@Bilalssbb Bilalssbb left a comment

doc: update property name

Copy link

@Bilalssbb Bilalssbb left a comment

doc: update property name

@Trott
Copy link
Member Author

@Trott Trott commented Mar 19, 2022

doc: update property name

User blocked.

@Trott Trott added the commit-queue label Mar 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label Mar 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4e2fefc into master Mar 21, 2022
23 checks passed
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Mar 21, 2022

Landed in 4e2fefc

@Trott Trott deleted the Trott-patch-1 branch Mar 21, 2022
juanarbol added a commit that referenced this issue Apr 4, 2022
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
juanarbol added a commit to juanarbol/node that referenced this issue Apr 5, 2022
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: nodejs#42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@juanarbol juanarbol mentioned this pull request Apr 5, 2022
@juanarbol juanarbol mentioned this pull request Apr 5, 2022
juanarbol added a commit that referenced this issue Apr 6, 2022
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready doc perf_hooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants