Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundantis_numeric and other checks for DataType #1613

Open
alamb opened this issue Jan 19, 2022 · 4 comments
Open

Remove redundantis_numeric and other checks for DataType #1613

alamb opened this issue Jan 19, 2022 · 4 comments
Labels
good first issue

Comments

@alamb
Copy link
Contributor

@alamb alamb commented Jan 19, 2022

arrow-rs has some functions to check data type, and the logic is also in datafusion, for example, https://docs.rs/arrow/7.0.0/arrow/datatypes/enum.DataType.html#method.is_numeric

We should reduce the redundancy in DataFusion to make the codebase clear.

Originally posted by @liukun4515 in #1606 (comment)
@alamb alamb mentioned this issue Jan 19, 2022
Merged
@liukun4515 liukun4515 mentioned this issue Jan 20, 2022
Merged
@alamb
Copy link
Contributor Author

@alamb alamb commented Jan 21, 2022

This is a good one -- just delete some code from DataFusion 👍

@HaoYang670
Copy link
Contributor

@HaoYang670 HaoYang670 commented Jan 27, 2022

is_numeric in arrow-rs seems not to be same as in arrow-datafusion because DataType::Decimal is not included.

@liukun4515
Copy link
Contributor

@liukun4515 liukun4515 commented Jan 27, 2022

is_numeric in arrow-rs seems not to be same as in arrow-datafusion because DataType::Decimal is not included.

@HaoYang670

In the PG or Spark, the decimal is included in the numeric.
Because the decimal is in development, some codes may be not consistent.

@liukun4515
Copy link
Contributor

@liukun4515 liukun4515 commented Jan 27, 2022

Now we can focus on other issues, and deal with them after other stabilization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@alamb @liukun4515 @HaoYang670