Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getInitialProps and getStaticProps regarding authentication #34334

Closed
balazsorban44 opened this issue Feb 14, 2022 · 3 comments
Closed

getInitialProps and getStaticProps regarding authentication #34334

balazsorban44 opened this issue Feb 14, 2022 · 3 comments
Assignees
@kmin-jeong
Labels
area: documentation good first issue

Comments

@balazsorban44
Copy link

@balazsorban44 balazsorban44 commented Feb 14, 2022 •
edited

What is the improvement or update you wish to see?

Given a developer is using both getInitialProps in a custom _app combined with a getStaticProps and revalidate on a page, we should inform the developer to make sure they don't accidentally cache sensitive information.

Is there any context that might help us understand?

See a more detailed answer giving an example with NextAuth.js and how to solve the issue instead.

#34316 (comment)

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/authentication
@molebox molebox added the good first issue label Mar 7, 2022
@kmin-jeong
Copy link

@kmin-jeong kmin-jeong commented Mar 24, 2022

@balazsorban44 @molebox If there's no one assign this issue, I want to try it. can I try it on?

@molebox
Copy link

@molebox molebox commented Mar 24, 2022

Sure @kmin-jeong its all yours!

@kmin-jeong kmin-jeong mentioned this issue Apr 17, 2022
Closed
5 tasks
@balazsorban44
Copy link
Author

@balazsorban44 balazsorban44 commented Apr 25, 2022

Closing, based on #36228 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmin-jeong kmin-jeong

Labels
area: documentation good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@balazsorban44 @molebox @kmin-jeong