C#: Buildless extractor option.#8230
Merged
michaelnebel merged 6 commits intogithub:mainfrom Mar 2, 2022
Merged
Conversation
michaelnebel
force-pushed
the
csharp/autobuilder-buildless
branch
from
6713e56 to
ce3dfb3
Compare
tamasvajk
previously approved these changes
Mar 1, 2022
hvitved
requested changes
Mar 1, 2022
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM, some small remarks.
csharp/ql/src/change-notes/2022-02-24-buildless-extractor-option.md
Outdated
Show resolved
Hide resolved
Contributor
Author
Sure, I will make the changes in the description. |
hvitved
reviewed
Mar 2, 2022
hvitved
previously approved these changes
Mar 2, 2022
hvitved
reviewed
Mar 2, 2022
csharp/ql/src/change-notes/2022-02-24-buildless-extractor-option.md
Outdated
Show resolved
Hide resolved
hvitved
previously approved these changes
Mar 2, 2022
…e extractor with the optional parameter.
michaelnebel
force-pushed
the
csharp/autobuilder-buildless
branch
from
747cf80 to
938902d
Compare
Contributor
Author
|
@hvitved Requested review again, as a rebase was needed. Otherwise no changes. |
hvitved
approved these changes
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce a new C# extractor option, which indicates, whether a tracing or buildless (standalone) extraction should be performed, when using the autobuilder.
Closes https://github.com/github/codeql-csharp-team/issues/205