assignment is unnessary under suppress()

[Dreamsorcerer]

Maybe a bit of an edge case, but this code gives warning of unnessary assignments:

            t = "<<Unknown>>"
            with suppress(AttributeError):
                # Set to type arg.
                t = cls = get_args(self.__orig_class__)[0]
                # If a class, set to the qualname.
                t = cls.__qualname__

It should probably recognise that any code in a suppress() block may not actually run to completion.

https://lgtm.com/projects/g/aio-libs/aiohttp/snapshot/d6d827d7b26f2a54999f8a150ef230fe627aa435/files/aiohttp/helpers.py?sort=name&dir=ASC&mode=heatmap#x6cb8804f71fae0f2:1

[tausbn]

Thank you for your report! I agree that in this case, we should not be issuing an alert.

As we're currently focused on improving our security analysis, and as this is not a problem that relates to security, we'll be adding to our backlog, and addressing it at a later date.

In the meantime, if you find the alerts annoying, you can suppress them as described in the LGTM.com help.