Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(multiple): remove coercion members #24055

Merged
merged 1 commit into from Dec 14, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 4, 2021

  • Replaces all usages of the ngAcceptInputType members with type declarations directly on the setters.
  • Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added.
@google-cla google-cla bot added the cla: yes label Dec 4, 2021
@crisbeto crisbeto force-pushed the coercion-members-again branch 3 times, most recently from ef519a1 to a5c2e4f Dec 4, 2021
@crisbeto crisbeto marked this pull request as ready for review Dec 4, 2021
* Replaces all usages of the `ngAcceptInputType` members with type declarations directly on the setters.
* Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added.
@crisbeto crisbeto force-pushed the coercion-members-again branch from a5c2e4f to f1f8b3b Dec 4, 2021
@amysorto amysorto merged commit 24180d1 into angular:master Dec 14, 2021
18 checks passed
amysorto added a commit that referenced this issue Dec 14, 2021
* Replaces all usages of the `ngAcceptInputType` members with type declarations directly on the setters.
* Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added.

(cherry picked from commit 24180d1)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jan 14, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants