Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno::Flags should be reference counted #13311

Open
ry opened this issue Jan 8, 2022 · 0 comments
Open

deno::Flags should be reference counted #13311

ry opened this issue Jan 8, 2022 · 0 comments
Labels
good first issue

Comments

@ry
Copy link
Member

@ry ry commented Jan 8, 2022 •
edited

The Flags struct has a lot of data in it and it is cloned multiple times. It makes sense to wrap it in an Rc.

For example:

deno/cli/main.rs

Line 378 in 1fb5858

let ps = ProcState::build(flags.clone()).await?;

deno/cli/main.rs

Line 572 in 1fb5858

let permissions = Permissions::from_options(&flags.clone().into());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ry