JS: Remove ATM CodeToFeatures library
#7575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use the `CodeToFeatures` AST, therefore these checks are defunct.
henrymercer
requested review from
annarailton
and removed request for
Z80coder
annarailton
reviewed
Jan 13, 2022
...rimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointFeatures.qll
Outdated
Show resolved
Hide resolved
annarailton
reviewed
Jan 13, 2022
annarailton
left a comment
annarailton
left a comment
There was a problem hiding this comment.
Just added some comments.
I think I've understood the changes here. Since this is meant to be a "zero diff" PR (i.e. not change any of the final behaviour), if the pipeline comes out with zero / near zero differences with this change in, I'm happy.
...rimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointFeatures.qll
Outdated
Show resolved
Hide resolved
...rimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointFeatures.qll
Outdated
Show resolved
Hide resolved
.../experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/BaseScoring.qll
Outdated
Show resolved
Hide resolved
...erimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointScoring.qll
Outdated
Show resolved
Hide resolved
The refactoring to remove the `CodeToFeatures` AST reintroduced a performance problem. This commit resolves it by pushing size restrictions into intermediate predicates.
henrymercer
force-pushed
the
henrymercer/atm-remove-code-to-features
branch
from
9a0a660 to
92d6fec
Compare
annarailton
approved these changes
Jan 14, 2022
annarailton
left a comment
annarailton
left a comment
There was a problem hiding this comment.
Thank you for the comment updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CodeToFeatureslibrary is now mostly a relic from older days, and is now unnecessarily complicated, getting in the way of onboarding new people to the codebase and optimizing queries. This PR (along with corresponding internal PRs) replaces it with much simpler definitions for theenclosingFunctionBodyandenclosingFunctionNamefeatures. These new definitions are behaviour-preserving but much more readable and maintainable.Commit-by-commit review recommended.