This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR to promote the JNDI Injection query created in #3288
Changes
Existing files were moved out of experimental.
The JndiInjectionLib.qll file was renamed to JndiInjection.qll and refactored to use the CSV sink model. Also, added new sinks.
No longer necessary .qll libs were removed from experimental. frameworks/Jndi.qll was kept, since it contains classes still in use.
Refactored tests to use InlineExpectationsTest.
To consider
UnsafeSearchControlsSink is probably worth reviewing - it uses a DataFlow::Configuration to detect new sinks receiving a SearchControls parameter with .setReturningObjFlag(true)
The text was updated successfully, but these errors were encountered:
⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The differences can be found in the comparison artifact of this workflow run.
@github/docs-content-codeql please review the qhelp file. Even though changes aren't introduced in this PR, it wasn't reviewed when this query was merged to experimental.
📚 Thanks for the docs ping! 🛎️ This was added to our docs first-responder project board. A team member will be along shortly to respond. To request changes to the docs you can also open a CodeQL docs issue.
⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The differences can be found in the comparison artifact of this workflow run.
⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged. The differences can be found in the comparison artifact of this workflow run.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
PR to promote the JNDI Injection query created in #3288
Changes
JndiInjectionLib.qllfile was renamed toJndiInjection.qlland refactored to use the CSV sink model. Also, added new sinks..qlllibs were removed from experimental.frameworks/Jndi.qllwas kept, since it contains classes still in use.InlineExpectationsTest.To consider
UnsafeSearchControlsSinkis probably worth reviewing - it uses aDataFlow::Configurationto detect new sinks receiving aSearchControlsparameter with.setReturningObjFlag(true)The text was updated successfully, but these errors were encountered: