Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https for slack link #1950

Merged
merged 1 commit into from Feb 1, 2021
Merged

use https for slack link #1950

merged 1 commit into from Feb 1, 2021

Conversation

@joprice
Copy link
Contributor

@joprice joprice commented Jan 24, 2021

I wanted to join the slack group, but the page seems to be broken. The iframe isn't loading because the invite url is using http, but the service seems to be available over https as well.

Copy link
Member

@garrettmoon garrettmoon left a comment

LGTM!

@bolsinga
Copy link
Member

@bolsinga bolsinga commented Jan 28, 2021

@joprice please sign the license

@joprice
Copy link
Contributor Author

@joprice joprice commented Jan 28, 2021

This one? https://cla-assistant.io/TextureGroup/Texture. I tried, but it throws an error for me. I assumed it was no longer in use.

@joprice
Copy link
Contributor Author

@joprice joprice commented Jan 31, 2021

Was able to sign now

@garrettmoon
Copy link
Member

@garrettmoon garrettmoon commented Feb 1, 2021

Thanks again!

@garrettmoon garrettmoon merged commit ad70335 into TextureGroup:master Feb 1, 2021
11 checks passed
11 checks passed
Verify that default subspecs lint
Details
Build and run tests
Details
Verify that other subspecs lint
Details
Build Texture as a dynamic framework
Details
Build Texture as a static library
Details
Verify that Carthage works
Details
Build examples (examples-pt1)
Details
Build examples (examples-pt2)
Details
Build examples (examples-pt3)
Details
Build examples (examples-pt4)
Details
license/cla Contributor License Agreement is signed.
Details
ZevEisenberg added a commit to ZevEisenberg/Texture that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants