Pinned
128 contributions in the last year
Less
More
Activity overview
Contribution activity
October 2021
Created 9 commits in 1 repository
Created a pull request in salesforce/near-membrane that received 86 comments
fix: remove use of proxy from live get/set traps
Reworked the traps to avoid using the proxy in the get/set trap
Avoids doubling the set operation and still resolves the set trap issue
+923
−1,436
•
86
comments
Opened 6 other pull requests in 1 repository
salesforce/near-membrane
1
open
5
merged
- chore: update and pin deps and lint
- chore: comment and var name cleanup and code inline pass
- feat: add dev_mode conditional compilation constant
- fix: ensure set trap returns consistent result with Reflect.set
- feat: cleanup getResolvedShapeDescriptors()
- fix: create correct branding of proxied objects
Reviewed 15 pull requests in 1 repository
salesforce/near-membrane
15 pull requests
- fix: remove use of proxy from live get/set traps
- chore: update and pin deps and lint
- fix: remove unused WindowPropertiesProtoDescriptors
- chore: comment and var name cleanup and code inline pass
- fix: guard against invalid own keys when resolving shape (specifically for Safari 14.x)
- fix: remove unused globalThis property from default options
- fix: ensure set trap returns consistent result with Reflect.set
- feat: return result of realm evaluation
- refactor: remove any trace of Window magic from base pkg
- fix: createVirtualEnvironment API to require a shape & target outside of options
- refactor: introduce marshall creation around init to reuse intrinsics and other shared values
- Caridy/marshall init tested
- chore: update examples with new createVirtualEnvironment(shape, {...}) api
- fix: ensure that globalObjectShape has a default value
- feat: return value from evaluator