Java: Extend String dataflow models #7019
Conversation
Marcono1234
force-pushed
the
marcono1234/extend-String-models
branch
from
55288d1
to
1fe4204
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,3,519,30,13,,,7,,,10
+ Java Standard Library,``java.*``,3,543,30,13,,,7,,,10
- Totals,,175,5341,408,13,6,10,107,33,1,66
+ Totals,,175,5365,408,13,6,10,107,33,1,66
- java.io,3,,27,,3,,,,,,,,,,,,,,,,,,,26,1
+ java.io,3,,29,,3,,,,,,,,,,,,,,,,,,,28,1
- java.lang,,,51,,,,,,,,,,,,,,,,,,,,,41,10
+ java.lang,,,72,,,,,,,,,,,,,,,,,,,,,52,20
- java.util,,,429,,,,,,,,,,,,,,,,,,,,,15,414
+ java.util,,,430,,,,,,,,,,,,,,,,,,,,,15,415 |
| @@ -11,19 +11,28 @@ private class StringSummaryCsv extends SummaryModelCsv { | |||
| "java.lang;String;false;concat;(String);;Argument[0];ReturnValue;taint", | |||
| "java.lang;String;false;concat;(String);;Argument[-1];ReturnValue;taint", | |||
| "java.lang;String;false;copyValueOf;;;Argument[0];ReturnValue;taint", | |||
| "java.lang;String;false;endsWith;;;Argument[-1];ReturnValue;taint", | |||
Have removed this because no other boolean returning methods are modelled.
| "java.lang;String;false;indent;;;Argument[-1];ReturnValue;taint", | ||
| "java.lang;String;false;intern;;;Argument[-1];ReturnValue;taint", | ||
| "java.lang;String;false;join;;;Argument[0..1];ReturnValue;taint", | ||
| "java.lang;String;false;join;;;Argument[0..1];ReturnValue;taint", // TODO: ArrayElement of Argument? |
Should this here and maybe also in other cases use ArrayElement of Argument instead? What is the difference between tracking taint form an array (or varargs?) compared to tracking taint from the elements?
| // TODO: Should `append` and `write` be modelled for Appendable and Writer instead? | ||
| // Could then remove some of the modelled `append` method here and for StringBuilder |
Should Appendable and Writer be modelled?
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,3,519,30,13,,,7,,,10
+ Java Standard Library,``java.*``,3,542,30,13,,,7,,,10
- Totals,,175,5341,408,13,6,10,107,33,1,66
+ Totals,,175,5364,408,13,6,10,107,33,1,66
- java.io,3,,27,,3,,,,,,,,,,,,,,,,,,,26,1
+ java.io,3,,29,,3,,,,,,,,,,,,,,,,,,,28,1
- java.lang,,,51,,,,,,,,,,,,,,,,,,,,,41,10
+ java.lang,,,71,,,,,,,,,,,,,,,,,,,,,51,20
- java.util,,,429,,,,,,,,,,,,,,,,,,,,,15,414
+ java.util,,,430,,,,,,,,,,,,,,,,,,,,,15,415 |
| "java.lang;StringBuilder;true;StringBuilder;(CharSequence);;Argument[0];Argument[-1];taint", | ||
| "java.lang;StringBuilder;true;StringBuilder;(String);;Argument[0];Argument[-1];taint", |
Have specified the parameter types here to avoid tracking StringBuilder(int) where the argument only represents the capacitiy.
Extends the dataflow String models to cover more methods.
I am not that familiar with the CSV model yet, and also don't know how to use the tools to automatically generate test cases.
Additionally there are a few open questions (see comments).
Any feedback is appreciated, but also feel free to just pick this changes up and complete them, if that would be easiest for you.
The text was updated successfully, but these errors were encountered: