src: add and fix some preprocessor comments #40701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been hidden.
This comment has been hidden.
43 tasks
lpinca
approved these changes
Nov 5, 2021
addaleax
approved these changes
Nov 5, 2021
44 tasks
|
Thank you for reviewing. |
46 tasks
46 tasks
JungMinu
approved these changes
Nov 8, 2021
23 tasks
|
Landed in 5e0dd79. |
tniessen
added a commit
that referenced
this issue
Nov 10, 2021
PR-URL: #40701 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
added a commit
that referenced
this issue
Nov 21, 2021
PR-URL: #40701 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes some comments related to preprocessor directives.
It also adds a few comments where the relation of
#endifto the corresponding#if/#ifdef/#elseis difficult to see (mostly because of the number of lines of code between the opening and closing directives).The text was updated successfully, but these errors were encountered: