Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-list): don't override focus styles with hover #23840

Merged
merged 1 commit into from Nov 15, 2021
Merged

fix(material-experimental/mdc-list): don't override focus styles with hover #23840

merged 1 commit into from Nov 15, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 27, 2021

Fixes that the :hover styles were overriding the :focus and selected effects of the MDC-based mat-list-option.

@crisbeto
fix(material-experimental/mdc-list): don't override focus styles with…
55f7496 
… hover

Fixes that the `:hover` styles were overriding the `:focus` and selected effects of the MDC-based `mat-list-option`.
@crisbeto crisbeto added P3 target: patch labels Oct 27, 2021
@crisbeto crisbeto requested a review from devversion Oct 27, 2021
@crisbeto crisbeto requested a review from mmalerba as a code owner Oct 27, 2021
@google-cla google-cla bot added the cla: yes label Oct 27, 2021
@crisbeto crisbeto added the merge ready label Oct 27, 2021
@mmalerba mmalerba merged commit edc2aa3 into angular:master Nov 15, 2021
18 checks passed
mmalerba pushed a commit that referenced this issue Nov 15, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-list): don't override focus styles with…
59ea116 
… hover (#23840)

Fixes that the `:hover` styles were overriding the `:focus` and selected effects of the MDC-based `mat-list-option`.

(cherry picked from commit edc2aa3)
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Dec 16, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion

@mmalerba mmalerba

Assignees
No one assigned
Labels
cla: yes merge ready P3 target: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @devversion @mmalerba