Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: format doc/api/*.md with markdown formatter #40403

Merged
merged 2 commits into from Oct 20, 2021
Merged

doc: format doc/api/*.md with markdown formatter #40403

merged 2 commits into from Oct 20, 2021

Conversation

@Trott
Copy link
Member

@Trott Trott commented Oct 11, 2021

No description provided.

Lxxyx
Lxxyx approved these changes Oct 11, 2021
View changes
@targos
Copy link
Member

@targos targos commented Oct 11, 2021 •
edited
Loading

Is there a way to view the diff without the empty new lines?

Loading

aduh95
aduh95 reviewed Oct 11, 2021
View changes
doc/api/child_process.md Outdated Show resolved Hide resolved
Loading
doc/api/repl.md Outdated Show resolved Hide resolved
Loading
doc/api/repl.md Outdated Show resolved Hide resolved
Loading
doc/api/repl.md Outdated Show resolved Hide resolved
Loading
doc/api/tty.md Outdated Show resolved Hide resolved
Loading
doc/api/cli.md Show resolved Hide resolved
Loading
@Trott Trott force-pushed the format-doc-api branch 2 times, most recently from d0e8013 to 37c63bd Oct 11, 2021
@Trott
Copy link
Member Author

@Trott Trott commented Oct 11, 2021

Is there a way to view the diff without the empty new lines?

While I don't think there is a way to do that in the GitHub interface, you can do git diff --ignore-blank-lines upstream/master if you are reviewing this branch on the command line.

Loading

@Trott
Copy link
Member Author

@Trott Trott commented Oct 11, 2021

Is there a way to view the diff without the empty new lines?

While I don't think there is a way to do that in the GitHub interface, you can do git diff --ignore-blank-lines upstream/master if you are reviewing this branch on the command line.

And if it saves anyone any trouble, here's what that will look like as of now: https://gist.github.com/Trott/0b5070042d8b2198e4f0d036fbfa606b

Loading

aduh95
aduh95 reviewed Oct 11, 2021
View changes
doc/api/cli.md Outdated Show resolved Hide resolved
Loading
doc/api/errors.md Outdated Show resolved Hide resolved
Loading
doc/api/errors.md Outdated Show resolved Hide resolved
Loading
doc/api/esm.md Outdated Show resolved Hide resolved
Loading
doc/api/esm.md Outdated Show resolved Hide resolved
Loading
doc/api/fs.md Outdated Show resolved Hide resolved
Loading
doc/api/fs.md Outdated Show resolved Hide resolved
Loading
doc/api/n-api.md Outdated Show resolved Hide resolved
Loading
doc/api/net.md Outdated Show resolved Hide resolved
Loading
doc/api/process.md Outdated Show resolved Hide resolved
Loading
@Trott Trott force-pushed the format-doc-api branch 8 times, most recently from 10fd7b2 to 90865c5 Oct 13, 2021
@Trott

This comment has been hidden.

Sign in to view
@targos
Copy link
Member

@targos targos commented Oct 13, 2021

It seems to break doc generation.

Loading

@Trott

This comment has been hidden.

Sign in to view
@Trott

This comment has been hidden.

Sign in to view
@Trott Trott force-pushed the format-doc-api branch 2 times, most recently from eb826f0 to d936976 Oct 13, 2021
@Trott
Copy link
Member Author

@Trott Trott commented Oct 13, 2021

It seems to break doc generation.

Well, that's bad....

Looks like I mistakenly added extra levels of headers when I did that mass n-api header edit.

All fixed up.

Loading

aduh95
aduh95 reviewed Oct 13, 2021
View changes
doc/api/n-api.md Outdated Show resolved Hide resolved
Loading
doc/api/net.md Outdated Show resolved Hide resolved
Loading
doc/api/readline.md Outdated Show resolved Hide resolved
Loading
doc/api/tls.md Outdated Show resolved Hide resolved
Loading
doc/api/webstreams.md Outdated Show resolved Hide resolved
Loading
doc/api/webstreams.md Outdated Show resolved Hide resolved
Loading
doc/api/worker_threads.md Outdated Show resolved Hide resolved
Loading
targos
targos approved these changes Oct 13, 2021
View changes
Copy link
Member

@targos targos left a comment

Changes in esm.md are a bit annoying, but I can live with them.

Please backport to v16.x-staging ASAP 🙏🏻

Loading

doc/api/tls.md Show resolved Hide resolved
Loading
doc/api/webstreams.md Outdated Show resolved Hide resolved
Loading
doc/api/webstreams.md Outdated Show resolved Hide resolved
Loading
doc/api/n-api.md Outdated Show resolved Hide resolved
Loading
@Trott Trott force-pushed the format-doc-api branch from d936976 to f4df473 Oct 13, 2021
@Trott Trott force-pushed the format-doc-api branch 7 times, most recently from a7bd829 to b83c938 Oct 20, 2021
@Trott
Copy link
Member Author

@Trott Trott commented Oct 20, 2021

All comments have been addressed I believe. Theoretically, this can land, but it would be good to have at least a quick review or re-review with the changes that were just made. Maybe @aduh95? (Although they've already done plenty on this one in terms of reviewing.)

Loading

@Trott Trott mentioned this pull request Oct 20, 2021
Closed
@Trott
Copy link
Member Author

@Trott Trott commented Oct 20, 2021

Please backport to v16.x-staging ASAP

#40530

Loading

aduh95
aduh95 approved these changes Oct 20, 2021
View changes
Copy link
Contributor

@aduh95 aduh95 left a comment

LGTM, thanks for all the work!

Loading

Trott added 2 commits Oct 20, 2021
@Trott @aduh95
test: adjust CLI flags test to ignore blank lines in doc
a7c17e0 
PR-URL: nodejs#40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott @aduh95
doc: format doc/api/*.md with markdown formatter
d0b58c0 
PR-URL: nodejs#40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the format-doc-api branch from b83c938 to d0b58c0 Oct 20, 2021
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 20, 2021

Landed in 4cb3e06...d0b58c0

Loading

@aduh95 aduh95 merged commit d0b58c0 into nodejs:master Oct 20, 2021
34 checks passed
Loading
@Trott Trott deleted the format-doc-api branch Oct 20, 2021
Trott added a commit to Trott/io.js that referenced this issue Oct 20, 2021
@Trott
test: adjust CLI flags test to ignore blank lines in doc
038121b 
PR-URL: nodejs#40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Oct 20, 2021
@Trott
doc: format doc/api/*.md with markdown formatter
ab54a10 
PR-URL: nodejs#40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this issue Oct 20, 2021
@Trott @targos
test: adjust CLI flags test to ignore blank lines in doc
3f7c503 
PR-URL: #40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this issue Oct 20, 2021
@Trott @targos
doc: format doc/api/*.md with markdown formatter
8dce85a 
PR-URL: #40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Oct 20, 2021
Merged
@Trott Trott mentioned this pull request Oct 20, 2021
Closed
targos added a commit that referenced this issue Nov 4, 2021
@Trott @targos
test: adjust CLI flags test to ignore blank lines in doc
6de88bc 
PR-URL: #40403
Backport-PR-URL: #40530
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this issue Nov 4, 2021
@Trott @targos
doc: format doc/api/*.md with markdown formatter
621266a 
PR-URL: #40403
Backport-PR-URL: #40530
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr

@targos targos

@Lxxyx Lxxyx

@aduh95 aduh95

Assignees
No one assigned
Labels
author ready backported-to-v16.x doc
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Trott @targos @aduh95 @benjamingr @Lxxyx @nodejs-github-bot