Apply highlight tags on numbers (not only strings) #1758
Comments
|
@curquiza I'll do, please assign it to me. |
|
Hello @spinales, you are assigned! |
|
Hello @curquiza I'm beginner with rust, can you give a hand, what function process the JSON files? |
|
@MarinPostma or @irevoire can maybe give you some clarification about the issue |
|
Hello @spinales, I think all your work will be in the You should notice that the big I think this should suffice but I may be wrong, do not hesitate to ask more questions if it doesn't work |
|
@irevoire Hi, how can test the changes i did? |
|
Hi @spinales, when you search for a specific document you can specify the |
|
Hello @spinales, I will remove the assignation since we did not get any PR from you, we can understand this is not an easy PR and you may not have the time to do it In general, and from now, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the other volunteers contributors to open a PR to fix this issue. thanks again for your involvement and feel free to still open a PR if you have the time |
|
@curquiza Sorry, I think this issue is easy to resolve, but I'm a beginner with Rust, I think that's the first problem. But the function that is used to search on string can be reused, as the number is a string in the end, that's a possible solution. |

Check with our PR @gmourier, this addition can be implemented by the community🎉
Currently, the search engine does not highlight the number in
_formattedbecause it's impossible to add<em>tag around a number (not a string) in JSON.What we expect?
Return the raw document (so the number) but the "transformed" document (so with the number surrounded of the tag in a string) in
_formatted.Example:
The text was updated successfully, but these errors were encountered: