Pinned
3,153 contributions in the last year
Less
More
Activity overview
Contributed to
vaadin/web-components,
modernweb-dev/web,
web-padawan/vanilla-colorful
and 5 other
repositories
Contribution activity
October 2021
Created 24 commits in 5 repositories
Created a pull request in vaadin/web-components that received 7 comments
refactor!: remove container part from public API
Description
Update to use CSS classes instead of part as in Vaadin 21 and older versions.
Fixes #2742
Type of change
Refactor
+55
−55
•
7
comments
Opened 15 other pull requests in 2 repositories
vaadin/web-components
2
open
12
merged
- refactor: cleanup no longer needed styles
- refactor!: move custom-field to new package
- refactor!: use more generic custom property name
- refactor!: move ControlStateMixin to field-base package
- chore: add details and accordion dev pages
- refactor: re-create vaadin-split-layout package
- refactor!: move vaadin-split-layout to split-layout
- refactor: re-create vaadin-progress-bar package
- refactor!: move vaadin-progress-bar to progress-bar
- test: add unit tests for autoselect property
- feat: improve accessibility based on ARIA 1.2
- chore: make husky pre-commit hook executable
- chore: add dev page for text-field
- fix: create default helper element lazily
modernweb-dev/web
1
merged
Reviewed 82 pull requests in 5 repositories
vaadin/web-components
64 pull requests
- refactor: cleanup no longer needed styles
- refactor!: move custom-field to new package
- refactor: re-create vaadin-rich-text-editor package
- refactor!: move vaadin-rich-text-editor to rich-text-editor
- refactor!: update date-time-picker to use slotted pickers
- refactor!: move vaadin-menu-bar to menu-bar
- refactor!: move ControlStateMixin to field-base package
- feat: add pattern validation to text area
- refactor: apply checkbox-group code review suggestions to radio-group
- refactor!: make checkbox-group use new mixins
- refactor: re-create vaadin-tabs for backwards compatibility
- refactor!: move vaadin-tabs to tabs
- refactor: re-create vaadin-notification for backwards compatibility
- refactor!: move vaadin-notifciation to notification
- refactor: re-create vaadin-combo-box package
- fix!: remove label part and enhance clickable area
- fix!: enhance clickable area for checkbox
- fix: do not fire custom-value-set event when readonly (CP: 21) (#2728) (CP: 20.0)
- refactor!: move vaadin-combo-box to combo-box
- revert: force highcharts to redraw when container's width changes (CP: 21) (#2762) (CP: 20.0)
- revert: force highcharts to redraw when container's width changes (CP: 21)
- refactor: re-create vaadin-time-picker for backwards compatibility
- fix: remove has-helper attribute when removing helper node
- refactor!: move vaadin-time-picker to time-picker
- refactor!: remove container part from public API
- Some pull request reviews not shown.
modernweb-dev/web
15 pull requests
- fix: update main entrypoint to point to dist
- fix(deps): update dependency @rocket/cli to ^0.10.0
- docs: clarify documentation about using dynamic imports
- fix(docs): example plugin should return undefined, not false
- chore(deps): update dependency @mdjs/mdjs-preview to ^0.5.2
- chore(deps): update dependency @mdjs/mdjs-story to ^0.3.0
- chore(deps): update dependency @mdjs/core to ^0.9.0
- Version Packages
- feat!: update dependency saucelabs to v6
-
docs: remove incorrect
dedupeoption example - chore(deps): lock file maintenance
- Version Packages
- fix(deps): update dependency @rocket/search to ^0.5.0
- fix(deps): update dependency @rocket/launch to ^0.6.0
- fix(deps): update dependency @rocket/blog to ^0.4.0
vaadin/vaadin-charts
1 pull request
web-padawan/awesome-lit
1 pull request
vaadin/vaadin-combo-box
1 pull request
Created an issue in vaadin/web-components that received 1 comment
Move ThemableMixin to component-base
Description
Move ThemableMixin package to @vaadin/component-base.
Keep register-styles.js and regisrter-styles.d.ts under vaadin-themable-mixin` p…
1
comment
Opened 15 other issues in 2 repositories
vaadin/web-components
8
open
6
closed
- Add focus listener to required indicator part rather than label part
-
[field-base] Rename
--vaadin-text-field-default-widthto use more generic name -
Move
vaadin-menu-barpackage tomenu-bar -
Drop
rendermethod from components that have it -
Move
vaadin-virtual-listpackage tovirtual-list -
Move
vaadin-rich-text-editorpackage torich-text-editor -
Move
vaadin-tabspackage totabs -
Move
vaadin-split-layoutpackage tosplit-layout -
Move
vaadin-progress-barpackage toprogress-bar -
Move
vaadin-notificationpackage tonotification - [menu-bar] Remove container part from public component API
- [combo-box] Issues with selected item announcements in VoiceOver
- [combo-box] Index of selected item is not always properly announced
- For Hacktoberfest 2021 participants