Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drop support for node 10 #930

Merged
merged 1 commit into from Jun 12, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 12, 2021

BREAKING CHANGE: node 10 is no longer supported. It reached its end-of-life on 30.04.2021.

What:

Closes #913
Closes #927

Why:

Reduces maintenance burden

How:

Change engines field to require node>=12

Checklist:

  • [ ] Documentation added to the
    docs site
    Will do once we release the alpha
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox
Copy link

@codesandbox codesandbox bot commented Jun 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 72dfb33:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 12, 2021

Codecov Report

Merging #930 (72dfb33) into alpha (c1878a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #930   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1878a9...72dfb33. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review Jun 12, 2021
@eps1lon eps1lon merged commit 42dad78 into testing-library:alpha Jun 12, 2021
13 checks passed
@eps1lon eps1lon deleted the feat/drop-node-10 branch Jun 12, 2021
@eps1lon eps1lon mentioned this pull request Jun 12, 2021
2 tasks
@eps1lon eps1lon mentioned this pull request Jun 12, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jun 12, 2021

🎉 This PR is included in version 12.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eps1lon eps1lon linked an issue that may be closed by this pull request Jun 12, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jun 23, 2021

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant